refactor: Unify bigquery execution paths #2007
Conversation
product-auto-label
bot
added
size: l
| self.expr, ordered=ordered, use_explicit_destination=allow_large_results | ||
| self.expr, | ||
| execution_spec.ExecutionSpec( | ||
| promise_under_10gb=under_10gb, |
There was a problem hiding this comment.
This threshold hasn't changed in a decade+, but I'm still wary of including it in the name. Perhaps requires_explicit_destination would better reflect the backend API?
There was a problem hiding this comment.
Chatted offline. This is intended to be somewhat backend-independent rather than prescriptive about constructing a table. Even if the threshold changes, it would only be to go up (to avoid breaking changes), so this naming should be OK, even if slightly inaccurate in that theoretical future.
| self.expr, ordered=ordered, use_explicit_destination=allow_large_results | ||
| self.expr, | ||
| execution_spec.ExecutionSpec( | ||
| promise_under_10gb=under_10gb, |
There was a problem hiding this comment.
Chatted offline. This is intended to be somewhat backend-independent rather than prescriptive about constructing a table. Even if the threshold changes, it would only be to go up (to avoid breaking changes), so this naming should be OK, even if slightly inaccurate in that theoretical future.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕